Webhook Formats
When I hooked this plugin to my discord, I noticed a few things about this plugin that seemed off, the first part being the formatting of the webhook. It is an unclear format, as there is no Header to tell you what command was executed at a glance. This is a major flaw in my opinion as I believe that we should be able to glance & find what punishment was given quickly.
Along with that, the way these webhooks are formatted is not the best nor really pleasing to the eye at all. While inline helps with it, (in my opinion). If we wanted to change any of these formats as well, to match a more generalistic theme, it would be currently impossible, so we are stuck with “Unmuter” instead of Operator, Moderator, or Administrator.
Lastly, the format given for mutes expiring is lackluster, simply “name mute expired”. While I do think it can be better, there is also no way to disable the mute expiration as there’s no hook.. and I’m going to assume that it hooks off of one of the mutes.
Warns
Warnings are meant to be accrued. However, there is no way to tell how many warnings a player has been given upon execution of the command nor in the logging of the command through webhooks. There is also no way to remove a warn from a player in the case of an accidental warn, wrong warn reason, etc. I think these additions should be added, more specifically the removal of a warn.
..
While I think the way this webhook was set up was for multiple channels, ex:warns, mutes, bans, etc.. this server is moreso centralized with its channels leading to a single punishment channel for all commands executed for this topic
—
There are some other things that I’ve noticed that don’t really need a section, in no particular order.
1) The Punishments table, I’m assuming is a compilation of all punishment commands executed, but it doesn’t seem to be logging any bans.
2) The info lookup for GEO/IP/HWID seems to function intermittently, mostly with GEO/IP not working.
3) If all HWID/IPs are being logged, there should be a table to store this information for further use, for example against comparisons if two players had the same HWID at the same time but then changed.
4) While not needed, the default configs table names could be bunched up together, ex: mod_players, mod_bans, etc.
PS;
I noticed that “Punishments” seem to be related to Warns rather than being a compilation, it should be renamed accordingly so other people don’t make the same confusion, with this being Unturned.